From mboxrd@z Thu Jan  1 00:00:00 1970
From: Asias He <asias.hejun@gmail.com>
Subject: Re: [PATCH 1/2] kvm tools: Use '-c' for '--cpus', not '--console'
Date: Thu, 12 May 2011 21:20:04 +0800
Message-ID: <4DCBDE84.5040202@gmail.com>
References: <1305136906-14496-1-git-send-email-penberg@kernel.org> <4DCB3336.5060401@gmail.com> <20110512071745.GP3191@elte.hu>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: Pekka Enberg <penberg@kernel.org>, kvm@vger.kernel.org,
	Avi Kivity <avi@redhat.com>,
	Cyrill Gorcunov <gorcunov@gmail.com>,
	Prasad Joshi <prasadjoshi124@gmail.com>,
	Sasha Levin <levinsasha928@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-px0-f173.google.com ([209.85.212.173]:54068 "EHLO
	mail-px0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753118Ab1ELNVY (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 12 May 2011 09:21:24 -0400
Received: by pxi16 with SMTP id 16so1000630pxi.4
        for <kvm@vger.kernel.org>; Thu, 12 May 2011 06:21:24 -0700 (PDT)
In-Reply-To: <20110512071745.GP3191@elte.hu>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 05/12/2011 03:17 PM, Ingo Molnar wrote:
> 
> * Asias He <asias.hejun@gmail.com> wrote:
> 
>> On 05/12/2011 02:01 AM, Pekka Enberg wrote:
>>> This patch changes the '-c' command line option to specify the number of CPUs
>>> because it's used more often than console switching.
>>
>> I'd like to tune the command line option further.
>>
>> 1)
>> Change
>>     -i, --image <image>   Disk image
>> to
>>     -d, --disk  <disk>	  Disk image
> 
> Agreed.
> 
>> 2)
>> Change
>>     -r, --initrd <initrd>
>>                           Initial RAM disk image
>> to
>>     -i, --initrd <initrd>
>>                           Initial RAM disk image
> 
> Agreed.
> 
>> 3)
>> Change
>>     -d, --kvm-dev <kvm-dev>
>>                           KVM device file
>>     -s, --single-step     Enable single stepping
>>     -g, --ioport-debug    Enable ioport debugging
>> to
>>         --kvm-dev <kvm-dev>
>>                           KVM device file
>>         --single-step     Enable single stepping
>>         --ioport-debug    Enable ioport debugging
> 
> Yeah, it would be nice to free up -d, -s, -g.
> 
> The debug options should probably be concentrated under a --debug option 
> anyway, to allow things like:
> 
>  --debug single-step,ioport
> 
> Even if the debug options are kept they should be streamlined along the same 
> pattern:
> 
>>         --debug-single-step     Enable single stepping
>>         --debug-ioport          Enable ioport debugging
> 
> But having a --debug option that recognizes all the debug flags would be nicer.
> 
> It would also allow future enhancements to group debug features, like:
> 
>   --debug all                # turn on everything and the kitchen sink for early hangs
>   --debug all,-single-step   # turn on everything except single-step debugging
>   --debug nonverbose         # turn on all non-noisy debug options we have
> 
> Maybe even:
> 
>   --debug memcheck
> 
> ... could run kvm under valgrind automatically - that way we can hide any 
> secondary tool complexities from the user and turn those tools into simple 
> debug options :-)

Great idea.

> 
> etc.
> 
>> So we can have
>> 	-c --cpus
>> 	-m --mem
>> 	-d --disk
>> 	-k --kernel
>> 	-i --initrd
>> which is more consistent and easy to remember.
> 
> Very nice plans!
> 
> The sooner we do this the fewer people will have to change their scripts and 
> practices.

Sure! I will cook a patch.

-- 
Best Regards,
Asias He