From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 03/16] Revert "qemu-kvm-x86: consider the irq0override flag in kvm_arch_init_irq_routing" Date: Mon, 16 May 2011 13:24:38 +0300 Message-ID: <4DD0FB66.4040109@redhat.com> References: <35f91d719f5ca7bbfa603f2c8be0ba9baf1b6120.1305288845.git.jan.kiszka@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:6400 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754026Ab1EPKYo (ORCPT ); Mon, 16 May 2011 06:24:44 -0400 In-Reply-To: <35f91d719f5ca7bbfa603f2c8be0ba9baf1b6120.1305288845.git.jan.kiszka@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On 05/13/2011 03:13 PM, Jan Kiszka wrote: > This reverts commit fd6bfef3d49a62b36092f131690de3e34f84662d. > > It is a nop, and it always was a nop: > > irq0override = !kvm_irqchip || kvm_has_gsi_routing > > But this code is only executed when gsi routing is available. That means that if kvm_has_gsi_routing, then irq0override = true, and this code is executed? -- error compiling committee.c: too many arguments to function