From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 04/16] qemu-kvm: Drop IRQ0 override test from ioapic_set_irq Date: Mon, 16 May 2011 13:29:34 +0300 Message-ID: <4DD0FC8E.1020905@redhat.com> References: <1f4e95a22a6397729461883d155916be032a9dba.1305288845.git.jan.kiszka@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:63292 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754219Ab1EPK3j (ORCPT ); Mon, 16 May 2011 06:29:39 -0400 In-Reply-To: <1f4e95a22a6397729461883d155916be032a9dba.1305288845.git.jan.kiszka@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On 05/13/2011 03:13 PM, Jan Kiszka wrote: > The IRQ0 override is not configurable while using the user space IOAPIC. > When the in-kernel irqchip is active, ioapic_set_irq is never called. So > drop this useless test. > > @@ -146,7 +145,7 @@ static void ioapic_set_irq(void *opaque, int vector, int level) > * the cleanest way of doing it but it should work. */ > > DPRINTF("%s: %s vec %x\n", __func__, level ? "raise" : "lower", vector); > - if (vector == 0&& irq0override) { > + if (vector == 0) { > vector = 2; > } > if (vector>= 0&& vector< IOAPIC_NUM_PINS) { Incidentally, the variable should be called pin, not vector, and gsi->ioapic/pic wiring should be done outside the ioapic code. -- error compiling committee.c: too many arguments to function