From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cyrill Gorcunov Subject: Re: [tip:tools/kvm] kvm tools: Add conditional compilation of symbol resolving Date: Sun, 22 May 2011 15:02:06 +0400 Message-ID: <4DD8ED2E.90508@gmail.com> References: <20110522105816.GA13373@elte.hu> <20110522110035.GA14865@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, mingo@redhat.com, hpa@zytor.com, heil@terminal-consulting.de, penberg@kernel.org, tglx@linutronix.de, linux-tip-commits@vger.kernel.org, KVM devel mailing list To: Ingo Molnar Return-path: Received: from mail-ew0-f46.google.com ([209.85.215.46]:41124 "EHLO mail-ew0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753446Ab1EVLCJ (ORCPT ); Sun, 22 May 2011 07:02:09 -0400 In-Reply-To: <20110522110035.GA14865@elte.hu> Sender: kvm-owner@vger.kernel.org List-ID: On 05/22/2011 03:00 PM, Ingo Molnar wrote: > > * Ingo Molnar wrote: > >> >> * tip-bot for Cyrill Gorcunov wrote: >> >>> diff --git a/tools/perf/feature-tests.mak b/tools/kvm/config/feature-tests.mak >>> similarity index 83% >>> copy from tools/perf/feature-tests.mak >>> copy to tools/kvm/config/feature-tests.mak >> >> Btw, now that we have feature-tests.mak it would be nice to populate the checks >> for the various assumptions. >> >> One i recently ran into on a new box where i tried to install tools/kvm was: >> >> In file included from /usr/include/features.h:387:0, >> from /usr/include/unistd.h:26, >> from include/kvm/util.h:12, >> from bios/e820.c:5: >> /usr/include/gnu/stubs.h:7:27: fatal error: gnu/stubs-32.h: No such file or directory >> compilation terminated. >> make: *** [bios/bios-rom.bin] Error 1 >> >> that's a dependency on glibc-dev[el]. > > Another detail: on 64-bit hosts the dependency is on gibc-dev[el].i686, i.e. > the 32-bit package. > > Would it be simple to remove this dependency? It's not typically installed by > default on distros and it would be nice to make most of the kvm code build by > default almost everywhere. > > Thanks, > > Ingo I'll take a look if we really need it (note we need to compile 16bit code for bios blob so it might eventually be a problem ;) -- Cyrill