From mboxrd@z Thu Jan  1 00:00:00 1970
From: Feng Yang <fyang@redhat.com>
Subject: Re: [PATCH] KVM Test: Switch current working folder in
 unattended_install.py.
Date: Mon, 23 May 2011 10:25:46 +0800
Message-ID: <4DD9C5AA.8070305@redhat.com>
References: <1305800662-21241-1-git-send-email-fyang@redhat.com>
	<1305917946.15658.12.camel@freedom>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: autotest@test.kernel.org, kvm@vger.kernel.org
To: Lucas Meneghel Rodrigues <lmr@redhat.com>
Return-path: <autotest-bounces@test.kernel.org>
In-Reply-To: <1305917946.15658.12.camel@freedom>
List-Unsubscribe: <http://test.kernel.org/cgi-bin/mailman/listinfo/autotest>,
	<mailto:autotest-request@test.kernel.org?subject=unsubscribe>
List-Archive: <http://test.kernel.org/pipermail/autotest>
List-Post: <mailto:autotest@test.kernel.org>
List-Help: <mailto:autotest-request@test.kernel.org?subject=help>
List-Subscribe: <http://test.kernel.org/cgi-bin/mailman/listinfo/autotest>,
	<mailto:autotest-request@test.kernel.org?subject=subscribe>
Sender: autotest-bounces@test.kernel.org
Errors-To: autotest-bounces@test.kernel.org
List-Id: kvm.vger.kernel.org

On 05/21/2011 02:59 AM, Lucas Meneghel Rodrigues wrote:
> On Thu, 2011-05-19 at 18:24 +0800, fyang@redhat.com wrote:
>> From: Feng Yang<fyang@redhat.com>
>>
>> Current working folder for
>>      unattended_install_config = UnattendedInstallConfig(test, params)
>>      unattended_install_config.setup()
>> must be kvm folder.
> This is not needed at all. What might be going on your setup is some
> incorrectly set or absent path that might be messing up with relative
> paths during your install.
>
> Please provide some more info so we can fix your problem properly.
> Meanwhile I'm marking this as 'rejected'.
>
> Thanks!
Thanks for your comment.
After merge upstream code to our local tree, I found that our local 
unattended_install could not work.
Before,  Current working folder for unattended.py  is kvm folder, 
changed in process_command.
Now  Current working folder for

     unattended_install_config = UnattendedInstallConfig(test, params)
     unattended_install_config.setup()

changed to case result folder. So our unattended_install always fails at 
could not find ks.iso.
Then I send this patch.

I will recheck our local code and configure.
Thanks very much!

Feng Yang
>> Signed-off-by: Feng Yang<fyang@redhat.com>
>> ---
>>   client/tests/kvm/tests/unattended_install.py |    3 +++
>>   1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/client/tests/kvm/tests/unattended_install.py b/client/tests/kvm/tests/unattended_install.py
>> index 50a8c7a..eee1761 100644
>> --- a/client/tests/kvm/tests/unattended_install.py
>> +++ b/client/tests/kvm/tests/unattended_install.py
>> @@ -506,8 +506,11 @@ def run_unattended_install(test, params, env):
>>       @param params: Dictionary with the test parameters.
>>       @param env: Dictionary with test environment.
>>       """
>> +    cur_folder = os.getcwd()
>> +    os.chdir(test.bindir)
>>       unattended_install_config = UnattendedInstallConfig(test, params)
>>       unattended_install_config.setup()
>> +    os.chdir(cur_folder)
>>       vm = env.get_vm(params["main_vm"])
>>       vm.create()
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html