From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 08/31] nVMX: Fix local_vcpus_link handling Date: Mon, 23 May 2011 19:51:55 +0300 Message-ID: <4DDA90AB.5010604@redhat.com> References: <20110517143532.GA2490@fermat.math.technion.ac.il> <4DD2902C.9050403@redhat.com> <20110517181132.GA16262@fermat.math.technion.ac.il> <20110517184336.GA10394@amt.cnet> <20110517193030.GA21656@fermat.math.technion.ac.il> <20110517195253.GB11065@amt.cnet> <20110518055236.GA1230@fermat.math.technion.ac.il> <20110518120801.GA9176@amt.cnet> <20110522085732.GB1116@fermat.math.technion.ac.il> <4DDA81FD.5050203@redhat.com> <20110523164325.GF27867@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "Nadav Har'El" , Marcelo Tosatti , "kvm@vger.kernel.org" , "gleb@redhat.com" To: "Roedel, Joerg" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:58876 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756674Ab1EWQwD (ORCPT ); Mon, 23 May 2011 12:52:03 -0400 In-Reply-To: <20110523164325.GF27867@amd.com> Sender: kvm-owner@vger.kernel.org List-ID: On 05/23/2011 07:43 PM, Roedel, Joerg wrote: > On Mon, May 23, 2011 at 11:49:17AM -0400, Avi Kivity wrote: > > > Joerg, is > > > > if (unlikely(cpu != vcpu->cpu)) { > > svm->asid_generation = 0; > > mark_all_dirty(svm->vmcb); > > } > > > > susceptible to cpu offline/online? > > I don't think so. This should be safe for cpu offline/online as long as > the cpu-number value is not reused for another physical cpu. But that > should be the case afaik. > Why not? offline/online does reuse cpu numbers AFAIK (and it must, if you have a fully populated machine and offline/online just one cpu). -- error compiling committee.c: too many arguments to function