From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 5/5 V2] kvm tools: Initialize and use VESA and VNC Date: Tue, 24 May 2011 14:30:18 +0300 Message-ID: <4DDB96CA.1030206@redhat.com> References: <1306149553-26793-1-git-send-email-levinsasha928@gmail.com> <1306149553-26793-5-git-send-email-levinsasha928@gmail.com> <20110523113824.GE4042@elte.hu> <4DDB6E55.8080408@redhat.com> <20110524085024.GA31453@elte.hu> <4DDB75EC.7000300@redhat.com> <4DDB9510.8030501@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Paolo Bonzini , Ingo Molnar , Sasha Levin , john@jfloren.net, kvm@vger.kernel.org, asias.hejun@gmail.com, gorcunov@gmail.com, prasadjoshi124@gmail.com To: Pekka Enberg Return-path: Received: from mx1.redhat.com ([209.132.183.28]:64118 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755236Ab1EXLag (ORCPT ); Tue, 24 May 2011 07:30:36 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 05/24/2011 02:26 PM, Pekka Enberg wrote: > Hi Avi, > > On Tue, May 24, 2011 at 2:22 PM, Avi Kivity wrote: > >> The point is to follow Linux kernel conventions and idioms (and share > >> code) as much as possible so it's familiar to devs who are already > >> working on the kernel. That's why section tricks seem more appropriate > >> than using constructor to me. Or is there some technical advantage to > >> using constructors? > > > > You get to reuse infrastructure that's already there. > > > > Things like using sections and s/uint64_t/u64/ look anti-reuse to me. > > Userspace isn't the kernel, for better or for worse. > > Not really. The type thing is pretty much required once you start > using kernel code (as we learned the hard way). What happens when you start using userspace libraries? Eventually you'll have a lot more of that than kernel code. > Btw, constructor attribute doesn't really seem like a good fit for > "late_initcall" type of thing: > > The constructor attribute causes the function to be called > automatically before execution enters main () > > What am I missing here? Like Paolo said, you can have the constructor register a function or structure to be called any time you like. -- error compiling committee.c: too many arguments to function