From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH 5/5 V2] kvm tools: Initialize and use VESA and VNC
Date: Tue, 24 May 2011 14:41:38 +0300
Message-ID: <4DDB9972.5050501@redhat.com>
References: <1306149553-26793-1-git-send-email-levinsasha928@gmail.com>	<1306149553-26793-5-git-send-email-levinsasha928@gmail.com>	<20110523113824.GE4042@elte.hu>	<4DDB6E55.8080408@redhat.com>	<20110524085024.GA31453@elte.hu>	<4DDB75EC.7000300@redhat.com>	<BANLkTin+32sFE_TnyNavQQh0FfC2HLC3xw@mail.gmail.com>	<4DDB9510.8030501@redhat.com>	<BANLkTi=6BSyK-8HRkgfkXN46bLt2RWqtVQ@mail.gmail.com>	<4DDB96CA.1030206@redhat.com> <BANLkTiko+LmU2hX-tKOOMGjrbp-pEt5OVA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Paolo Bonzini <pbonzini@redhat.com>, Ingo Molnar <mingo@elte.hu>,
	Sasha Levin <levinsasha928@gmail.com>, john@jfloren.net,
	kvm@vger.kernel.org, asias.hejun@gmail.com, gorcunov@gmail.com,
	prasadjoshi124@gmail.com
To: Pekka Enberg <penberg@kernel.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:64529 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751098Ab1EXLlx (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 24 May 2011 07:41:53 -0400
In-Reply-To: <BANLkTiko+LmU2hX-tKOOMGjrbp-pEt5OVA@mail.gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 05/24/2011 02:38 PM, Pekka Enberg wrote:
> Hi Avi,
>
> On Tue, May 24, 2011 at 2:30 PM, Avi Kivity<avi@redhat.com>  wrote:
> >  What happens when you start using userspace libraries?
> >
> >  Eventually you'll have a lot more of that than kernel code.
>
> I don't quite understand what problems you think we might have. We're
> already using userspace libraries (libvnc) and most of us code is
> non-kernel code.

If uint64_t is defined differently than u64, you won't be able to pass 
it by reference if an external library expects it.

> We switched to u64 and friends for two reasons: (1) using uint*_t
> turned out to be painful when using kernel headers (e.g., mptables,
> e820, etc.) and (2) we want to be as close as possible to the coding
> style of tools/perf to be able to reuse their code in the future.
>

Regarding this reuse, I see it's done by copy/paste.  Won't it be better 
to have tools/lib and have tools/perf and tools/kvm use that?

-- 
error compiling committee.c: too many arguments to function