From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 5/5 V2] kvm tools: Initialize and use VESA and VNC Date: Tue, 24 May 2011 17:38:23 +0300 Message-ID: <4DDBC2DF.5070206@redhat.com> References: <1306149553-26793-1-git-send-email-levinsasha928@gmail.com> <1306149553-26793-5-git-send-email-levinsasha928@gmail.com> <20110523113824.GE4042@elte.hu> <4DDB6E55.8080408@redhat.com> <20110524085024.GA31453@elte.hu> <4DDB75EC.7000300@redhat.com> <4DDB9510.8030501@redhat.com> <4DDB96CA.1030206@redhat.com> <4DDB9972.5050501@redhat.com> <4DDBA42C.7040208@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Pekka Enberg , Ingo Molnar , Sasha Levin , john@jfloren.net, kvm@vger.kernel.org, asias.hejun@gmail.com, gorcunov@gmail.com, prasadjoshi124@gmail.com To: Paolo Bonzini Return-path: Received: from mx1.redhat.com ([209.132.183.28]:22094 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932506Ab1EXOif (ORCPT ); Tue, 24 May 2011 10:38:35 -0400 In-Reply-To: <4DDBA42C.7040208@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 05/24/2011 03:27 PM, Paolo Bonzini wrote: > On 05/24/2011 01:56 PM, Pekka Enberg wrote: >>> > If uint64_t is defined differently than u64, you won't be able to >>> pass it by >>> > reference if an external library expects it. >> >> Oh, the sizes must be the same for obvious reasons so that shouldn't >> be a problem and it's better to do the casting in the external API >> calls than in core code. > > Be careful about unsigned long vs. unsigned long long. Yes, that's the issue I had in mind. > If you want to use the u64 spelling that's fine, but I would use a > custom header that defines it from uint64_t. And now you'll have printf/printk format mismatches if they happen to be different. -- error compiling committee.c: too many arguments to function