From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: KVM: x86: use proper port value when checking io instruction
 permission
Date: Tue, 24 May 2011 22:25:07 +0300
Message-ID: <4DDC0613.40706@redhat.com>
References: <20110524171120.GA19906@amt.cnet> <20110524172706.GC22042@redhat.com> <4DDC0204.9050002@redhat.com> <20110524191836.GD22042@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm <kvm@vger.kernel.org>,
	Joerg Roedel <joerg.roedel@amd.com>
To: Gleb Natapov <gleb@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:47978 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1756931Ab1EXTZN (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 24 May 2011 15:25:13 -0400
In-Reply-To: <20110524191836.GD22042@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 05/24/2011 10:18 PM, Gleb Natapov wrote:
> >  Note we haven't decoded operands yet.  And this doesn't fix in $imm8, %al.
> >
> We haven't? check_perm is called from x86_emulate_insn() and operands are
> decode in x86_decode_insn(). So $imm8, %al should work now. Or am I
> missing something?

No, you're right.  SrcDX seems the simplest fix then.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.