From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: KVM: x86: use proper port value when checking io instruction permission (v2) Date: Thu, 26 May 2011 10:04:24 +0300 Message-ID: <4DDDFB78.9070307@redhat.com> References: <20110524171120.GA19906@amt.cnet> <20110524172706.GC22042@redhat.com> <20110525181820.GA14921@amt.cnet> <4DDDF3D6.3000505@redhat.com> <20110526065511.GA29458@redhat.com> <4DDDFB07.2050909@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm , Joerg Roedel To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:51063 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751339Ab1EZHE3 (ORCPT ); Thu, 26 May 2011 03:04:29 -0400 In-Reply-To: <4DDDFB07.2050909@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 05/26/2011 10:02 AM, Avi Kivity wrote: > >> Can >> c->op_bytes ever be 1? > > in %dx, %al > er, that doesn't change op_bytes. Still, op_bytes is irrelevant for SrcDX, the 16-bit version is always used. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.