From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [Patch v3] Enable CPU SMEP feature for KVM
Date: Sun, 29 May 2011 09:42:30 +0300
Message-ID: <4DE1EAD6.1040902@redhat.com>
References: <5D8008F58939784290FAB48F54975198419FBE82D2@shsmsx502.ccr.corp.intel.com> <4DDF64A9.1000001@redhat.com> <FC2FB65B4D919844ADE4BE3C2BB739AD5AA81842@shsmsx501.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "Yang, Wei Y" <wei.y.yang@intel.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
To: "Li, Xin" <xin.li@intel.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:37668 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751241Ab1E2Gmg (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sun, 29 May 2011 02:42:36 -0400
In-Reply-To: <FC2FB65B4D919844ADE4BE3C2BB739AD5AA81842@shsmsx501.ccr.corp.intel.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 05/29/2011 08:16 AM, Li, Xin wrote:
> >
> >  >  +		else
> >  >  +			best->ebx&= ~(bit(X86_FEATURE_SMEP));
> >
> >  Not needed - x86.c already masks unsupported features.
>
> Should KVM still support guest SMEP when host disables it thru nosmep?

No.  We treat nosmep as "no smep for the kernel and any guests".  NX is 
treated in the same way.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.