From: Avi Kivity <avi@redhat.com>
To: "Li, Xin" <xin.li@intel.com>
Cc: "Yang, Wei Y" <wei.y.yang@intel.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [Patch v3] Enable CPU SMEP feature for KVM
Date: Sun, 29 May 2011 10:20:47 +0300 [thread overview]
Message-ID: <4DE1F3CF.1060607@redhat.com> (raw)
In-Reply-To: <FC2FB65B4D919844ADE4BE3C2BB739AD5AA8184D@shsmsx501.ccr.corp.intel.com>
On 05/29/2011 10:15 AM, Li, Xin wrote:
> > > >
> > > > > + else
> > > > > + best->ebx&= ~(bit(X86_FEATURE_SMEP));
> > > >
> > > > Not needed - x86.c already masks unsupported features.
> > >
> > > Should KVM still support guest SMEP when host disables it thru nosmep?
> >
> > No. We treat nosmep as "no smep for the kernel and any guests". NX is
> > treated in the same way.
>
> Then we need to add logic to do_cpuid_ent to mask off leaf 7 features when host
> disables it.
Yes.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
prev parent reply other threads:[~2011-05-29 7:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-26 13:28 [Patch v3] Enable CPU SMEP feature for KVM Yang, Wei Y
2011-05-27 2:56 ` Tian, Kevin
2011-05-27 8:47 ` Avi Kivity
2011-05-27 8:45 ` Avi Kivity
2011-05-29 5:16 ` Li, Xin
2011-05-29 6:42 ` Avi Kivity
2011-05-29 7:15 ` Li, Xin
2011-05-29 7:20 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DE1F3CF.1060607@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=wei.y.yang@intel.com \
--cc=xin.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox