From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH] testdev: adjust for ISA irq changes Date: Sun, 29 May 2011 17:05:55 +0200 Message-ID: <4DE260D3.4090507@web.de> References: <1306673851-23152-1-git-send-email-avi@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigB445CDC8999F9375900BA1B7" Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from fmmailgate01.web.de ([217.72.192.221]:56079 "EHLO fmmailgate01.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752761Ab1E2PGB (ORCPT ); Sun, 29 May 2011 11:06:01 -0400 In-Reply-To: <1306673851-23152-1-git-send-email-avi@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigB445CDC8999F9375900BA1B7 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable On 2011-05-29 14:57, Avi Kivity wrote: > Recent changes killed the ioapic_irq_hack hack, use the isa_get_irq() A= PI > instead. >=20 > Signed-off-by: Avi Kivity > --- > hw/isa-bus.c | 2 +- > hw/testdev.c | 4 +--- > 2 files changed, 2 insertions(+), 4 deletions(-) >=20 > diff --git a/hw/isa-bus.c b/hw/isa-bus.c > index 2765543..7e06efc 100644 > --- a/hw/isa-bus.c > +++ b/hw/isa-bus.c > @@ -66,7 +66,7 @@ void isa_bus_irqs(qemu_irq *irqs) > */ > qemu_irq isa_get_irq(int isairq) > { > - if (isairq < 0 || isairq > 15) { > + if (isairq < 0 || isairq > 23) { That's a fairly evil hack. It will break again when we clean up the kvm irqchips (not to speak of side effects in non-irqchip/non-kvm mode). Why not hook into the kvm irqchip directly? Would keep generic code out of this business until we have real irq pin manipulation in qemu. Jan --------------enigB445CDC8999F9375900BA1B7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk3iYNcACgkQitSsb3rl5xS3DgCdFHkf5tXs7y6vLg4RBlZ6zkcy Nd4An3it2+oSkZE5L5kvTQcRi2XxAVaM =jsng -----END PGP SIGNATURE----- --------------enigB445CDC8999F9375900BA1B7--