From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 07/20] qemu-kvm: Clean up kvm_update_interrupt_request Date: Sun, 29 May 2011 19:16:01 +0300 Message-ID: <4DE27141.8020003@redhat.com> References: <6331a7b381965d2577b993606e2ad86743db3281.1306498737.git.jan.kiszka@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:20499 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752282Ab1E2QQK (ORCPT ); Sun, 29 May 2011 12:16:10 -0400 In-Reply-To: <6331a7b381965d2577b993606e2ad86743db3281.1306498737.git.jan.kiszka@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On 05/27/2011 03:19 PM, Jan Kiszka wrote: > Most tests in kvm_update_interrupt_request are unneeded today: > - env argument is always non-NULL (caller references it as well) > - current_env must have been created when we get here > - env->thread can't be zero (initialized early during cpu creation) > > So simply avoid self signaling and multiple kicks, drop the rest. > Why must there be a current_env? Although the logic you remove seems to be meaningless. It folds back to the new code whether current_env is set or not. -- error compiling committee.c: too many arguments to function