From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 08/20] qemu-kvm: Replace kvm_update_interrupt_request with qemu_cpu_kick Date: Sun, 29 May 2011 19:19:13 +0300 Message-ID: <4DE27201.3000209@redhat.com> References: <4f71a2111ae8c62ef042ec81563411789c00d7dc.1306498737.git.jan.kiszka@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:32444 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750992Ab1E2QTT (ORCPT ); Sun, 29 May 2011 12:19:19 -0400 In-Reply-To: <4f71a2111ae8c62ef042ec81563411789c00d7dc.1306498737.git.jan.kiszka@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On 05/27/2011 03:19 PM, Jan Kiszka wrote: > Activate the iothread version of qemu_cpu_kick. We just need to > initialize the yet unused CPUState::halt_cond for it. > > This finally obsoletes kvm_update_interrupt_request, so drop it. > void qemu_cpu_kick(void *_env) { CPUState *env = _env; qemu_cond_broadcast(env->halt_cond); if (!env->thread_kicked) { qemu_cpu_kick_thread(env); env->thread_kicked = true; } } Seems to have redundancies - we're both signalling a condition variable and sending a signal. -- error compiling committee.c: too many arguments to function