From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH 07/20] qemu-kvm: Clean up kvm_update_interrupt_request Date: Sun, 29 May 2011 18:37:38 +0200 Message-ID: <4DE27652.2040504@web.de> References: <6331a7b381965d2577b993606e2ad86743db3281.1306498737.git.jan.kiszka@siemens.com> <4DE27141.8020003@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig15167C849C2E9083B5D00064" Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from fmmailgate02.web.de ([217.72.192.227]:42518 "EHLO fmmailgate02.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754404Ab1E2Qhl (ORCPT ); Sun, 29 May 2011 12:37:41 -0400 In-Reply-To: <4DE27141.8020003@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig15167C849C2E9083B5D00064 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2011-05-29 18:16, Avi Kivity wrote: > On 05/27/2011 03:19 PM, Jan Kiszka wrote: >> Most tests in kvm_update_interrupt_request are unneeded today: >> - env argument is always non-NULL (caller references it as well) >> - current_env must have been created when we get here >> - env->thread can't be zero (initialized early during cpu creation) >> >> So simply avoid self signaling and multiple kicks, drop the rest. >> >=20 > Why must there be a current_env? >=20 > Although the logic you remove seems to be meaningless. It folds back t= o > the new code whether current_env is set or not. Are you commenting on the removed code or on the new one now? I assume to old complex current_env check was once added to work around initialization ordering problems. I do not see them in the way qemu starts up, but I also do not have a clear picture of the original issues anymore. Jan --------------enig15167C849C2E9083B5D00064 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk3idlIACgkQitSsb3rl5xSH+wCcCsADGEaIWfUYP+LiAU6GJd4r 7KkAoJJXwefgNOnDQndbh+ZIwsKoFNJp =aSdN -----END PGP SIGNATURE----- --------------enig15167C849C2E9083B5D00064--