From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 07/20] qemu-kvm: Clean up kvm_update_interrupt_request Date: Sun, 29 May 2011 19:41:01 +0300 Message-ID: <4DE2771D.90901@redhat.com> References: <6331a7b381965d2577b993606e2ad86743db3281.1306498737.git.jan.kiszka@siemens.com> <4DE27141.8020003@redhat.com> <4DE27652.2040504@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:5719 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752375Ab1E2QlF (ORCPT ); Sun, 29 May 2011 12:41:05 -0400 In-Reply-To: <4DE27652.2040504@web.de> Sender: kvm-owner@vger.kernel.org List-ID: On 05/29/2011 07:37 PM, Jan Kiszka wrote: > On 2011-05-29 18:16, Avi Kivity wrote: > > On 05/27/2011 03:19 PM, Jan Kiszka wrote: > >> Most tests in kvm_update_interrupt_request are unneeded today: > >> - env argument is always non-NULL (caller references it as well) > >> - current_env must have been created when we get here > >> - env->thread can't be zero (initialized early during cpu creation) > >> > >> So simply avoid self signaling and multiple kicks, drop the rest. > >> > > > > Why must there be a current_env? > > > > Although the logic you remove seems to be meaningless. It folds back to > > the new code whether current_env is set or not. > > Are you commenting on the removed code or on the new one now? The old code - it seems dead already. > I assume to old complex current_env check was once added to work around > initialization ordering problems. I do not see them in the way qemu > starts up, but I also do not have a clear picture of the original issues > anymore. Yeah, it was probably a make-it-work hack. I don't think we have to worry about anything there now, though. -- error compiling committee.c: too many arguments to function