From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH 08/20] qemu-kvm: Replace kvm_update_interrupt_request with qemu_cpu_kick Date: Sun, 29 May 2011 18:41:59 +0200 Message-ID: <4DE27757.90500@web.de> References: <4f71a2111ae8c62ef042ec81563411789c00d7dc.1306498737.git.jan.kiszka@siemens.com> <4DE27201.3000209@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig452640631F4A9A00B99E73B1" Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from fmmailgate03.web.de ([217.72.192.234]:48692 "EHLO fmmailgate03.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752375Ab1E2QmB (ORCPT ); Sun, 29 May 2011 12:42:01 -0400 In-Reply-To: <4DE27201.3000209@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig452640631F4A9A00B99E73B1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2011-05-29 18:19, Avi Kivity wrote: > On 05/27/2011 03:19 PM, Jan Kiszka wrote: >> Activate the iothread version of qemu_cpu_kick. We just need to >> initialize the yet unused CPUState::halt_cond for it. >> >> This finally obsoletes kvm_update_interrupt_request, so drop it. >> >=20 > void qemu_cpu_kick(void *_env) > { > CPUState *env =3D _env; >=20 > qemu_cond_broadcast(env->halt_cond); > if (!env->thread_kicked) { > qemu_cpu_kick_thread(env); > env->thread_kicked =3D true; > } > } >=20 > Seems to have redundancies - we're both signalling a condition variable= > and sending a signal. >=20 The target may block on the halt condition or run in guest mode. I don't think we can (and should) try to find out which wakeup call is sufficient= =2E Jan --------------enig452640631F4A9A00B99E73B1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk3id1cACgkQitSsb3rl5xT4pwCgrWozL8op0o8SWuPWrmp9Speu C20AnRdW4pZ3/rwGNIzQ1BjzX4iqvO6D =iV4b -----END PGP SIGNATURE----- --------------enig452640631F4A9A00B99E73B1--