From: Avi Kivity <avi@redhat.com>
To: "Yang, Wei Y" <wei.y.yang@intel.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [Patch v5 3/4] Mask function7 ebx against host capability word9
Date: Mon, 30 May 2011 14:44:14 +0300 [thread overview]
Message-ID: <4DE3830E.1040606@redhat.com> (raw)
In-Reply-To: <5D8008F58939784290FAB48F5497519844E92781E1@shsmsx502.ccr.corp.intel.com>
On 05/30/2011 06:01 AM, Yang, Wei Y wrote:
> This patch masks CPUID leaf 7 ebx against host capability word9.
>
> }
> break;
> }
> + case 7:
> + /* Mask ebx against host capability word 9 */
> + if (index == 0) cpuid_mask(&entry->ebx, 9);
> + break;
> + /* function 0xb has additional index. */
> case 0xb: {
> int i, level_type;
>
It's not just masking leaf 7. It's enabling it - before we passed 0
every time.
So we need to give it the same treatment as other leaves. We expose a
bit only if we explicitly support it in kvm, and it is enabled in the
host. See kvm_supported_word[01456] features for examples.
btw, we could also expose fsgsbase and rep/movsb (but in a separate
patch, please).
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2011-05-30 11:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-30 3:01 [Patch v5 3/4] Mask function7 ebx against host capability word9 Yang, Wei Y
2011-05-30 11:44 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DE3830E.1040606@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=wei.y.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox