From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 08/20] qemu-kvm: Replace kvm_update_interrupt_request with qemu_cpu_kick Date: Mon, 30 May 2011 18:10:34 +0300 Message-ID: <4DE3B36A.8070505@redhat.com> References: <4f71a2111ae8c62ef042ec81563411789c00d7dc.1306498737.git.jan.kiszka@siemens.com> <4DE27201.3000209@redhat.com> <4DE27757.90500@web.de> <4DE277E0.3000106@redhat.com> <4DE2888E.7040101@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:53506 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753280Ab1E3PKi (ORCPT ); Mon, 30 May 2011 11:10:38 -0400 In-Reply-To: <4DE2888E.7040101@web.de> Sender: kvm-owner@vger.kernel.org List-ID: On 05/29/2011 08:55 PM, Jan Kiszka wrote: > > What we could do is make both waiters wait for the same event. > > That may only work if we are able to switch halt_cond to a signal-based > mechanism. As usual, a portability issue. I don't think there is much to > win /wrt performance (cond_broadcast is fast). So the question is if > code complexity could actually benefit from this. > Unlikely; kicks should be rare these days. -- error compiling committee.c: too many arguments to function