From: Avi Kivity <avi@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>, kvm <kvm@vger.kernel.org>,
Joerg Roedel <joerg.roedel@amd.com>
Subject: Re: KVM: x86: use proper port value when checking io instruction permission (v4)
Date: Mon, 30 May 2011 21:28:38 +0300 [thread overview]
Message-ID: <4DE3E1D6.9080108@redhat.com> (raw)
In-Reply-To: <20110530182314.GA2719@amt.cnet>
On 05/30/2011 09:23 PM, Marcelo Tosatti wrote:
> Commit fa4491a6b667304 moved the permission check for io instructions
> to the ->check_perm callback. It failed to copy the port value from RDX
> register for string and "in,out ax,dx" instructions.
>
> Fix it by reading RDX register at decode stage when appropriate.
>
> Fixes FC8.32 installation.
>
Looks good.
We should really unify Src/Dst encoding and fetching.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next prev parent reply other threads:[~2011-05-30 18:28 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-24 17:11 KVM: x86: use proper port value when checking io instruction permission Marcelo Tosatti
2011-05-24 17:27 ` Gleb Natapov
2011-05-24 19:07 ` Avi Kivity
2011-05-24 19:18 ` Gleb Natapov
2011-05-24 19:25 ` Avi Kivity
2011-05-25 18:18 ` KVM: x86: use proper port value when checking io instruction permission (v2) Marcelo Tosatti
2011-05-26 6:31 ` Avi Kivity
2011-05-26 6:55 ` Gleb Natapov
2011-05-26 7:02 ` Avi Kivity
2011-05-26 7:04 ` Avi Kivity
2011-05-26 7:07 ` Gleb Natapov
2011-05-26 7:49 ` Paolo Bonzini
2011-05-26 8:26 ` Gleb Natapov
2011-05-26 9:00 ` Paolo Bonzini
2011-05-26 9:02 ` Gleb Natapov
2011-05-26 9:23 ` Paolo Bonzini
2011-05-26 9:29 ` Gleb Natapov
2011-05-26 10:43 ` Marcelo Tosatti
2011-05-26 11:56 ` KVM: x86: use proper port value when checking io instruction permission (v3) Marcelo Tosatti
2011-05-29 8:34 ` Avi Kivity
2011-05-30 18:23 ` KVM: x86: use proper port value when checking io instruction permission (v4) Marcelo Tosatti
2011-05-30 18:28 ` Avi Kivity [this message]
2011-05-30 18:23 ` KVM: x86: use proper port value when checking io instruction permission (v3) Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DE3E1D6.9080108@redhat.com \
--to=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=joerg.roedel@amd.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox