From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: KVM: x86: use proper port value when checking io instruction
 permission (v4)
Date: Mon, 30 May 2011 21:28:38 +0300
Message-ID: <4DE3E1D6.9080108@redhat.com>
References: <20110524171120.GA19906@amt.cnet> <20110524172706.GC22042@redhat.com> <20110525181820.GA14921@amt.cnet> <4DDDF3D6.3000505@redhat.com> <20110526115605.GA29882@amt.cnet> <4DE20523.7080707@redhat.com> <20110530182314.GA2719@amt.cnet>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Gleb Natapov <gleb@redhat.com>, kvm <kvm@vger.kernel.org>,
	Joerg Roedel <joerg.roedel@amd.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:12459 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750757Ab1E3S2o (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 30 May 2011 14:28:44 -0400
In-Reply-To: <20110530182314.GA2719@amt.cnet>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 05/30/2011 09:23 PM, Marcelo Tosatti wrote:
> Commit fa4491a6b667304 moved the permission check for io instructions
> to the ->check_perm callback. It failed to copy the port value from RDX
> register for string and "in,out ax,dx" instructions.
>
> Fix it by reading RDX register at decode stage when appropriate.
>
> Fixes FC8.32 installation.
>

Looks good.

We should really unify Src/Dst encoding and fetching.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.