From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH] kvm: Fix build warnings
Date: Tue, 31 May 2011 11:20:55 +0300
Message-ID: <4DE4A4E7.80503@redhat.com>
References: <20110530124600.GB494@eferding.osrc.amd.com> <1306786278-12219-1-git-send-email-bp@alien8.de> <20110531073824.GA17999@elte.hu>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Borislav Petkov <bp@alien8.de>,
	Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
To: Ingo Molnar <mingo@elte.hu>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20110531073824.GA17999@elte.hu>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On 05/31/2011 10:38 AM, Ingo Molnar wrote:
> * Borislav Petkov<bp@alien8.de>  wrote:
>
> >  +++ b/arch/x86/kvm/paging_tmpl.h
> >  @@ -121,7 +121,7 @@ static int FNAME(walk_addr_generic)(struct guest_walker *walker,
> >   				gva_t addr, u32 access)
> >   {
> >   	pt_element_t pte;
> >  -	pt_element_t __user *ptep_user;
> >  +	pt_element_t __user *uninitialized_var(ptep_user);
>
> Note that doing this is actually actively dangerous for two reasons.
>
>

<snip lots of good advice>

> Please fix it instead.

s/instead/in addition/; while all those changes are good, they are much 
too large for 3.0.  Let's push the simple fix for 3.0 and queue the 
bigger refactoring to 3.1.

-- 
error compiling committee.c: too many arguments to function