From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: drop -enable-nesting Date: Tue, 31 May 2011 11:58:16 +0300 Message-ID: <4DE4ADA8.5000503@redhat.com> References: <4DDAD5CF.5050805@redhat.com> <4DE0B4B1.1000407@web.de> <20110530081847.GC27062@amd.com> <4DE3A3EC.80201@siemens.com> <20110530143846.GA2957@fermat.math.technion.ac.il> <4DE3B1E2.7020006@siemens.com> <20110530151020.GB7855@amd.com> <4DE3B4A5.6050509@siemens.com> <4DE3B572.6030105@redhat.com> <20110531084429.GA2671@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Anthony Liguori , Nadav Har'El , kvm , john cooper , Jan Kiszka , "qemu-devel@nongnu.org" , "Roedel, Joerg" To: "Daniel P. Berrange" Return-path: In-Reply-To: <20110531084429.GA2671@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org On 05/31/2011 11:44 AM, Daniel P. Berrange wrote: > > I think it's safe to drop -enable-nesting immediately. Dan, does > > libvirt make use of it? > > Yes, but it should be safe to drop it. Currently, if the user specifies > a CPU with the 'svm' flag present in libvirt guest XML, then we will > pass args '-cpu ....+svm -enable-nesting'. So if we drop --enable-nesting, > then libvirt will simply omit it and everything should still work because > we have still got +svm set. But qemu will complain about an option it can't parse. -- error compiling committee.c: too many arguments to function