From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus Schade Subject: Re: Restoring saved guest causes guest to reboot Date: Tue, 31 May 2011 11:44:51 +0200 Message-ID: <4DE4B893.6040902@markusschade.com> References: <20110524130208.GJ23407@8bytes.org> <4DDBB085.2010907@redhat.com> <4DDBB5D3.3020403@redhat.com> <4DDCA687.9080506@gmail.com> <4DDDF6D1.1070907@redhat.com> <4DDE3975.6020709@gmail.com> <4DDE6FC0.3010801@gmail.com> <20110526152516.GM23407@8bytes.org> <20110530180246.GA9285@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Markus Schade , Joerg Roedel , Avi Kivity , kvm@vger.kernel.org To: Marcelo Tosatti Return-path: Received: from jack.hrz.tu-chemnitz.de ([134.109.132.46]:40055 "EHLO jack.hrz.tu-chemnitz.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750762Ab1EaKTP (ORCPT ); Tue, 31 May 2011 06:19:15 -0400 In-Reply-To: <20110530180246.GA9285@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: Am 30.05.2011 20:02, schrieb Marcelo Tosatti: > On Mon, May 30, 2011 at 02:16:41PM +0200, Markus Schade wrote: >> On Thu, 26 May 2011, Joerg Roedel wrote: >> >>> On Thu, May 26, 2011 at 05:20:32PM +0200, Markus Schade wrote: >>>> I have re-added the missing 4 lines to ept_update_paging_mode_cr0 in >>>> vmx.c, which resolves this issue for in Kernel 2.6,37 and 2.6.39. >>>> I haven't tested all guests, but neither Squeeze nor 2008 R2 reboot anymore. >>> >>> Hmm, not 100% sure, but the issue might be that the arch.cr3 value does >>> not make it into the vmcs after cr3 was changed from user-space? This >>> would also be fixed with the change above. >> >> So, basically, Linus just has to re-pull, since the >> "change" I made is already in the tree. Or is there another way to solve >> this? I find it hard to believe that I am the only one using >> save/restore on Nehalem CPUs or that this bug only affects me. >> Although I can verify this on dozens of machines. > > Markus, > > Please check whether the following patch fixes the problem for you. Thanks, I will try that. But I won't be able to get back to you before next week (short week in Germany *g*) Markus