Re: [Patch v4 2/4] Add SMEP handling when setting CR4

Marcelo Tosatti
2011-05-31T18:51:44Z

On Tue, May 31, 2011 at 09:05:35PM +0300, Avi Kivity wrote:
> >> if (is_long_mode(vcpu)) {
> >> if (!(cr4& X86_CR4_PAE))
> >> return 1;
> >
> >A new field in vcpu->arch.mmu.base_role for smep is required
> >for shadow MMU (similar to nxe).
>
> I plan to add that with my cr0.wp=0 fixup (it's only needed there, right?)

Sptes instantiated when cr4.smep = 0 should not be used when cr4.smep =
1, so no (unlikely that guest kernel executes user=1 code anyway, but
for consistency with other base_role flags).

OK then, you'll fix that.