From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] [RFC PATCH 01/13] Generic DMA memory
	access interface
Date: Wed, 01 Jun 2011 17:29:56 +0300
Message-ID: <4DE64CE4.7030300@redhat.com>
References: <1306892315-7306-1-git-send-email-eduard.munteanu@linux360.ro>
	<1306892315-7306-2-git-send-email-eduard.munteanu@linux360.ro>
	<4DE64646.3010505@twiddle.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Cc: aliguori@us.ibm.com, kvm@vger.kernel.org, mst@redhat.com, aik@ozlabs.ru,
	joro@8bytes.org, seabios@seabios.org, qemu-devel@nongnu.org,
	agraf@suse.de, blauwirbel@gmail.com, yamahata@valinux.co.jp,
	paul@codesourcery.com,
	Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>,
	dwg@au1.ibm.com, david@gibson.dropbear.id.au
To: Richard Henderson <rth@twiddle.net>
Return-path: <seabios-bounces+gcbcs-seabios=m.gmane.org@seabios.org>
In-Reply-To: <4DE64646.3010505@twiddle.net>
List-Unsubscribe: <http://www.seabios.org/mailman/options/seabios>,
	<mailto:seabios-request@seabios.org?subject=unsubscribe>
List-Archive: <http://www.seabios.org/pipermail/seabios>
List-Post: <mailto:seabios@seabios.org>
List-Help: <mailto:seabios-request@seabios.org?subject=help>
List-Subscribe: <http://www.seabios.org/mailman/listinfo/seabios>,
	<mailto:seabios-request@seabios.org?subject=subscribe>
Errors-To: seabios-bounces+gcbcs-seabios=m.gmane.org@seabios.org
Sender: seabios-bounces+gcbcs-seabios=m.gmane.org@seabios.org
List-Id: kvm.vger.kernel.org

On 06/01/2011 05:01 PM, Richard Henderson wrote:
> >  +        err = dev->mmu->translate(dev, addr,&paddr,&plen, is_write);
>
> I see you didn't take my suggestion for using an opaque callback pointer.
> Really and truly, I won't be able to use this as-is for Alpha.
>

Rather than opaques, please pass the DMA engine itself and use 
container_of().

We should be removing opaques, not adding them.

-- 
error compiling committee.c: too many arguments to function