Re: [Qemu-devel] [RFC PATCH 01/13] Generic DMA memory access interface

Avi Kivity
2011-06-01T14:29:56Z

On 06/01/2011 05:01 PM, Richard Henderson wrote:
> > + err = dev->mmu->translate(dev, addr,&paddr,&plen, is_write);
>
> I see you didn't take my suggestion for using an opaque callback pointer.
> Really and truly, I won't be able to use this as-is for Alpha.
>

Rather than opaques, please pass the DMA engine itself and use
container_of().

We should be removing opaques, not adding them.

--
error compiling committee.c: too many arguments to function