* [PATCH] KVM: Clarify KVM_ASSIGN_PCI_DEVICE documentation
@ 2011-06-02 14:16 Jan Kiszka
2011-06-03 2:04 ` Marcelo Tosatti
0 siblings, 1 reply; 6+ messages in thread
From: Jan Kiszka @ 2011-06-02 14:16 UTC (permalink / raw)
To: Avi Kivity, Marcelo Tosatti; +Cc: kvm
From: Jan Kiszka <jan.kiszka@siemens.com>
Neither host_irq nor the guest_msi struct are used anymore today.
Tag the former, drop the latter to avoid confusion.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
Documentation/virtual/kvm/api.txt | 7 +------
1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/Documentation/virtual/kvm/api.txt b/Documentation/virtual/kvm/api.txt
index 2bd06b0..7adc1ac 100644
--- a/Documentation/virtual/kvm/api.txt
+++ b/Documentation/virtual/kvm/api.txt
@@ -1143,15 +1143,10 @@ Assigns an IRQ to a passed-through device.
struct kvm_assigned_irq {
__u32 assigned_dev_id;
- __u32 host_irq;
+ __u32 host_irq; /* ignored (legacy field) */
__u32 guest_irq;
__u32 flags;
union {
- struct {
- __u32 addr_lo;
- __u32 addr_hi;
- __u32 data;
- } guest_msi;
__u32 reserved[12];
};
};
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] KVM: Clarify KVM_ASSIGN_PCI_DEVICE documentation
2011-06-02 14:16 [PATCH] KVM: Clarify KVM_ASSIGN_PCI_DEVICE documentation Jan Kiszka
@ 2011-06-03 2:04 ` Marcelo Tosatti
2011-06-03 6:51 ` [PATCH v2] " Jan Kiszka
0 siblings, 1 reply; 6+ messages in thread
From: Marcelo Tosatti @ 2011-06-03 2:04 UTC (permalink / raw)
To: Jan Kiszka; +Cc: Avi Kivity, kvm
On Thu, Jun 02, 2011 at 04:16:09PM +0200, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> Neither host_irq nor the guest_msi struct are used anymore today.
> Tag the former, drop the latter to avoid confusion.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> Documentation/virtual/kvm/api.txt | 7 +------
> 1 files changed, 1 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/virtual/kvm/api.txt b/Documentation/virtual/kvm/api.txt
> index 2bd06b0..7adc1ac 100644
> --- a/Documentation/virtual/kvm/api.txt
> +++ b/Documentation/virtual/kvm/api.txt
> @@ -1143,15 +1143,10 @@ Assigns an IRQ to a passed-through device.
>
> struct kvm_assigned_irq {
> __u32 assigned_dev_id;
> - __u32 host_irq;
> + __u32 host_irq; /* ignored (legacy field) */
> __u32 guest_irq;
> __u32 flags;
> union {
> - struct {
> - __u32 addr_lo;
> - __u32 addr_hi;
> - __u32 data;
> - } guest_msi;
> __u32 reserved[12];
> };
> };
Please update the kernel headers accordingly.
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v2] KVM: Clarify KVM_ASSIGN_PCI_DEVICE documentation
2011-06-03 2:04 ` Marcelo Tosatti
@ 2011-06-03 6:51 ` Jan Kiszka
2011-06-06 8:42 ` Avi Kivity
0 siblings, 1 reply; 6+ messages in thread
From: Jan Kiszka @ 2011-06-03 6:51 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: Avi Kivity, kvm
From: Jan Kiszka <jan.kiszka@siemens.com>
Neither host_irq nor the guest_msi struct are used anymore today.
Tag the former, drop the latter to avoid confusion.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
Documentation/virtual/kvm/api.txt | 7 +------
include/linux/kvm.h | 8 +-------
2 files changed, 2 insertions(+), 13 deletions(-)
diff --git a/Documentation/virtual/kvm/api.txt b/Documentation/virtual/kvm/api.txt
index 2bd06b0..0ebe922 100644
--- a/Documentation/virtual/kvm/api.txt
+++ b/Documentation/virtual/kvm/api.txt
@@ -1143,15 +1143,10 @@ Assigns an IRQ to a passed-through device.
struct kvm_assigned_irq {
__u32 assigned_dev_id;
- __u32 host_irq;
+ __u32 host_irq; /* ignored (legacy field) */
__u32 guest_irq;
__u32 flags;
union {
- struct {
- __u32 addr_lo;
- __u32 addr_hi;
- __u32 data;
- } guest_msi;
__u32 reserved[12];
};
};
diff --git a/include/linux/kvm.h b/include/linux/kvm.h
index 55ef181..9c9ca7c 100644
--- a/include/linux/kvm.h
+++ b/include/linux/kvm.h
@@ -773,20 +773,14 @@ struct kvm_assigned_pci_dev {
struct kvm_assigned_irq {
__u32 assigned_dev_id;
- __u32 host_irq;
+ __u32 host_irq; /* ignored (legacy field) */
__u32 guest_irq;
__u32 flags;
union {
- struct {
- __u32 addr_lo;
- __u32 addr_hi;
- __u32 data;
- } guest_msi;
__u32 reserved[12];
};
};
-
struct kvm_assigned_msix_nr {
__u32 assigned_dev_id;
__u16 entry_nr;
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2] KVM: Clarify KVM_ASSIGN_PCI_DEVICE documentation
2011-06-03 6:51 ` [PATCH v2] " Jan Kiszka
@ 2011-06-06 8:42 ` Avi Kivity
2011-06-06 19:57 ` Jan Kiszka
0 siblings, 1 reply; 6+ messages in thread
From: Avi Kivity @ 2011-06-06 8:42 UTC (permalink / raw)
To: Jan Kiszka; +Cc: Marcelo Tosatti, kvm
On 06/03/2011 09:51 AM, Jan Kiszka wrote:
> From: Jan Kiszka<jan.kiszka@siemens.com>
>
> Neither host_irq nor the guest_msi struct are used anymore today.
> Tag the former, drop the latter to avoid confusion.
>
> diff --git a/include/linux/kvm.h b/include/linux/kvm.h
> index 55ef181..9c9ca7c 100644
> --- a/include/linux/kvm.h
> +++ b/include/linux/kvm.h
> @@ -773,20 +773,14 @@ struct kvm_assigned_pci_dev {
>
> struct kvm_assigned_irq {
> __u32 assigned_dev_id;
> - __u32 host_irq;
> + __u32 host_irq; /* ignored (legacy field) */
> __u32 guest_irq;
> __u32 flags;
> union {
> - struct {
> - __u32 addr_lo;
> - __u32 addr_hi;
> - __u32 data;
> - } guest_msi;
> __u32 reserved[12];
> };
> };
>
> -
> struct kvm_assigned_msix_nr {
> __u32 assigned_dev_id;
> __u16 entry_nr;
Can we just drop a definition like this? When did we last use this?
(in fact I can't find when we *ever* used this)
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] KVM: Clarify KVM_ASSIGN_PCI_DEVICE documentation
2011-06-06 8:42 ` Avi Kivity
@ 2011-06-06 19:57 ` Jan Kiszka
2011-06-09 8:13 ` Avi Kivity
0 siblings, 1 reply; 6+ messages in thread
From: Jan Kiszka @ 2011-06-06 19:57 UTC (permalink / raw)
To: Avi Kivity; +Cc: Marcelo Tosatti, kvm
[-- Attachment #1: Type: text/plain, Size: 1419 bytes --]
On 2011-06-06 10:42, Avi Kivity wrote:
> On 06/03/2011 09:51 AM, Jan Kiszka wrote:
>> From: Jan Kiszka<jan.kiszka@siemens.com>
>>
>> Neither host_irq nor the guest_msi struct are used anymore today.
>> Tag the former, drop the latter to avoid confusion.
>>
>
>> diff --git a/include/linux/kvm.h b/include/linux/kvm.h
>> index 55ef181..9c9ca7c 100644
>> --- a/include/linux/kvm.h
>> +++ b/include/linux/kvm.h
>> @@ -773,20 +773,14 @@ struct kvm_assigned_pci_dev {
>>
>> struct kvm_assigned_irq {
>> __u32 assigned_dev_id;
>> - __u32 host_irq;
>> + __u32 host_irq; /* ignored (legacy field) */
>> __u32 guest_irq;
>> __u32 flags;
>> union {
>> - struct {
>> - __u32 addr_lo;
>> - __u32 addr_hi;
>> - __u32 data;
>> - } guest_msi;
>> __u32 reserved[12];
>> };
>> };
>>
>> -
>> struct kvm_assigned_msix_nr {
>> __u32 assigned_dev_id;
>> __u16 entry_nr;
>
> Can we just drop a definition like this? When did we last use this?
>
> (in fact I can't find when we *ever* used this)
>
The kernel interface was present between in 2.6.29 only. The fact that
we simply dropped that API (replacing it with the current one) indicates
that no one was expecting this to be actually used.
I also do not find any traces of the old way of assigning MSIs in qemu-kvm.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] KVM: Clarify KVM_ASSIGN_PCI_DEVICE documentation
2011-06-06 19:57 ` Jan Kiszka
@ 2011-06-09 8:13 ` Avi Kivity
0 siblings, 0 replies; 6+ messages in thread
From: Avi Kivity @ 2011-06-09 8:13 UTC (permalink / raw)
To: Jan Kiszka; +Cc: Marcelo Tosatti, kvm
On 06/06/2011 10:57 PM, Jan Kiszka wrote:
> >
> > Can we just drop a definition like this? When did we last use this?
> >
> > (in fact I can't find when we *ever* used this)
> >
>
> The kernel interface was present between in 2.6.29 only. The fact that
> we simply dropped that API (replacing it with the current one) indicates
> that no one was expecting this to be actually used.
>
> I also do not find any traces of the old way of assigning MSIs in qemu-kvm.
>
Okay. There's some remote possibility that someone will pick up .29 and
develop for it, but I think we can ignore that. Applied.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-06-09 8:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-02 14:16 [PATCH] KVM: Clarify KVM_ASSIGN_PCI_DEVICE documentation Jan Kiszka
2011-06-03 2:04 ` Marcelo Tosatti
2011-06-03 6:51 ` [PATCH v2] " Jan Kiszka
2011-06-06 8:42 ` Avi Kivity
2011-06-06 19:57 ` Jan Kiszka
2011-06-09 8:13 ` Avi Kivity
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox