From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH v3 1/8] ARM: KVM: Initial skeleton to compile KVM support Date: Fri, 03 Jun 2011 17:31:04 +0200 Message-ID: <4DE8FE38.6030405@siemens.com> References: <20110603150318.17011.82777.stgit@ubuntu> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: catalin.marinas@arm.com, android-virt@lists.cs.columbia.edu, s.raho@virtualopensystems.com, a.motakis@virtualopensystems.com, c.dall@virtualopensystems.com, kvm@vger.kernel.org, a.costa@virtualopensystems.com To: Christoffer Dall Return-path: Received: from goliath.siemens.de ([192.35.17.28]:27768 "EHLO goliath.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753809Ab1FCPbX (ORCPT ); Fri, 3 Jun 2011 11:31:23 -0400 In-Reply-To: <20110603150318.17011.82777.stgit@ubuntu> Sender: kvm-owner@vger.kernel.org List-ID: On 2011-06-03 17:03, Christoffer Dall wrote: > Targets KVM support for Cortex A-15 processors. > > Contains no real functionality but all the framework components, > make files, header files and some tracing functionality. > --- ... > diff --git a/include/linux/kvm.h b/include/linux/kvm.h > index ea2dc1a..d2ab07e 100644 > --- a/include/linux/kvm.h > +++ b/include/linux/kvm.h > @@ -310,6 +310,7 @@ struct kvm_translation { > struct kvm_interrupt { > /* in */ > __u32 irq; > + __u8 raise; > }; This touches an existing ABI and corrupts the definition of KVM_INTERRUPT IOCTL. The might exist jurisdictions considering this a capital crime. :) You rather have to define a new CPU IRQ injection interface that supports both raising and lowering and declare its availability via a KVM_CAP. Don't forget to make it extensible (flags field) so that future requirements can be added without breaking existing users. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux