From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH v1 5/5] KVM: Expose a version 1 architectural PMU to guests
Date: Sun, 05 Jun 2011 11:12:58 +0300
Message-ID: <4DEB3A8A.9060401@redhat.com>
References: <1305129333-7456-1-git-send-email-avi@redhat.com>	 <1305129333-7456-6-git-send-email-avi@redhat.com> <1307112113.2353.3391.camel@twins>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
	Ingo Molnar <mingo@elte.hu>,
	Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <1307112113.2353.3391.camel@twins>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On 06/03/2011 05:41 PM, Peter Zijlstra wrote:
> On Wed, 2011-05-11 at 11:55 -0400, Avi Kivity wrote:
> >  +static u64 read_gp_pmc(struct kvm_pmu *pmu, struct kvm_pmc *pmc)
> >  +{
> >  +       u64 counter, enabled, running;
> >  +
> >  +       counter = pmc->counter;
> >  +
> >  +       if (pmc->perf_event)
> >  +               counter += perf_event_read_value(pmc->perf_event,
> >  +&enabled,&running);
> >  +
> >  +       /* FIXME: Scaling needed? */
>
> Yeah, either that or use attr.pinned = 1, doing the latter will result
> in an error when the PMU is overloaded though.

So what's the scale factor? enabled / running?

-- 
error compiling committee.c: too many arguments to function