From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH v3 1/8] ARM: KVM: Initial skeleton to compile KVM support Date: Sun, 05 Jun 2011 15:21:46 +0300 Message-ID: <4DEB74DA.2040909@redhat.com> References: <20110603150318.17011.82777.stgit@ubuntu> <4DE8FE38.6030405@siemens.com> <4DE90397.5080801@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Christoffer Dall , catalin.marinas@arm.com, android-virt@lists.cs.columbia.edu, s.raho@virtualopensystems.com, a.motakis@virtualopensystems.com, c.dall@virtualopensystems.com, kvm@vger.kernel.org, a.costa@virtualopensystems.com To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:34261 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756021Ab1FEMWN (ORCPT ); Sun, 5 Jun 2011 08:22:13 -0400 In-Reply-To: <4DE90397.5080801@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On 06/03/2011 06:53 PM, Jan Kiszka wrote: > >> @@ -310,6 +310,7 @@ struct kvm_translation { > >> struct kvm_interrupt { > >> /* in */ > >> __u32 irq; > >> + __u8 raise; > >> }; > > > > This touches an existing ABI and corrupts the definition of > > KVM_INTERRUPT IOCTL. The might exist jurisdictions considering this a > > capital crime. :) > > > > You rather have to define a new CPU IRQ injection interface that > > supports both raising and lowering This is KVM_IRQ_LINE: > and declare its availability via a > > KVM_CAP. Don't forget to make it extensible (flags field) so that future > > requirements can be added without breaking existing users. > > Or much easier (this is what PowerPC is doing): Define irq values in a > way that they include a raise/lower flag. Much easier and much horribler. -- error compiling committee.c: too many arguments to function