From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH v3 1/8] ARM: KVM: Initial skeleton to compile KVM support Date: Sun, 05 Jun 2011 15:52:16 +0300 Message-ID: <4DEB7C00.30600@redhat.com> References: <20110603150318.17011.82777.stgit@ubuntu> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: catalin.marinas@arm.com, android-virt@lists.cs.columbia.edu, s.raho@virtualopensystems.com, a.motakis@virtualopensystems.com, c.dall@virtualopensystems.com, kvm@vger.kernel.org, a.costa@virtualopensystems.com To: Christoffer Dall Return-path: Received: from mx1.redhat.com ([209.132.183.28]:50618 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755889Ab1FEMwj (ORCPT ); Sun, 5 Jun 2011 08:52:39 -0400 In-Reply-To: <20110603150318.17011.82777.stgit@ubuntu> Sender: kvm-owner@vger.kernel.org List-ID: On 06/03/2011 06:03 PM, Christoffer Dall wrote: > Targets KVM support for Cortex A-15 processors. > > Contains no real functionality but all the framework components, > make files, header files and some tracing functionality. (series review - please have a cover letter in the future for this stuff) Looks good in general. Of course I can't say much about technical correctness and will rely on the ARM maintainers for that. Please document which ioctls are supported in Documentation/virtual/kvm/api.txt, and make sure that any ARM-specific ioctls (if you ever have any) are documented there. -- error compiling committee.c: too many arguments to function