From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH v3 1/8] ARM: KVM: Initial skeleton to compile KVM support Date: Sun, 05 Jun 2011 16:13:54 +0200 Message-ID: <4DEB8F22.1020802@web.de> References: <20110603150318.17011.82777.stgit@ubuntu> <4DE8FE38.6030405@siemens.com> <4DE90397.5080801@siemens.com> <4DEB74DA.2040909@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigC2444FC023FA2C71A127EE67" Cc: Christoffer Dall , catalin.marinas@arm.com, android-virt@lists.cs.columbia.edu, s.raho@virtualopensystems.com, a.motakis@virtualopensystems.com, c.dall@virtualopensystems.com, kvm@vger.kernel.org, a.costa@virtualopensystems.com To: Avi Kivity Return-path: Received: from fmmailgate02.web.de ([217.72.192.227]:36083 "EHLO fmmailgate02.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754079Ab1FEOPa (ORCPT ); Sun, 5 Jun 2011 10:15:30 -0400 In-Reply-To: <4DEB74DA.2040909@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigC2444FC023FA2C71A127EE67 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2011-06-05 14:21, Avi Kivity wrote: > On 06/03/2011 06:53 PM, Jan Kiszka wrote: >> >> @@ -310,6 +310,7 @@ struct kvm_translation { >> >> struct kvm_interrupt { >> >> /* in */ >> >> __u32 irq; >> >> + __u8 raise; >> >> }; >> > >> > This touches an existing ABI and corrupts the definition of >> > KVM_INTERRUPT IOCTL. The might exist jurisdictions considering this= a >> > capital crime. :) >> > >> > You rather have to define a new CPU IRQ injection interface that >> > supports both raising and lowering >=20 > This is KVM_IRQ_LINE: >=20 It's so far associated with in-kernel irqchip input pins, not with raising CPU IRQs. >=20 >=20 >> and declare its availability via a >> > KVM_CAP. Don't forget to make it extensible (flags field) so that >> future >> > requirements can be added without breaking existing users. >> >> Or much easier (this is what PowerPC is doing): Define irq values in a= >> way that they include a raise/lower flag. >=20 > Much easier and much horribler. >=20 Less horrible than overloading KVM_IRQ_LINE IMHO. The semantics of kvm_interrupt::irq are in arch hands anyway. Jan --------------enigC2444FC023FA2C71A127EE67 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk3rjyYACgkQitSsb3rl5xRtzgCgvLIGl9h375Hc8UTn+Hd3wZyh 8XMAoKFxSrwZTHb3r1fTu3uhItSi9gMl =iQ+2 -----END PGP SIGNATURE----- --------------enigC2444FC023FA2C71A127EE67--