From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH v3 1/8] ARM: KVM: Initial skeleton to compile KVM support Date: Sun, 05 Jun 2011 16:58:22 +0200 Message-ID: <4DEB998E.1010805@web.de> References: <20110603150318.17011.82777.stgit@ubuntu> <4DE8FE38.6030405@siemens.com> <4DE90397.5080801@siemens.com> <4DEB74DA.2040909@redhat.com> <4DEB8F22.1020802@web.de> <4DEB9033.9060109@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig88DAAEE34D9FB08C43F98487" Cc: Christoffer Dall , catalin.marinas@arm.com, android-virt@lists.cs.columbia.edu, s.raho@virtualopensystems.com, a.motakis@virtualopensystems.com, c.dall@virtualopensystems.com, kvm@vger.kernel.org, a.costa@virtualopensystems.com To: Avi Kivity Return-path: Received: from fmmailgate01.web.de ([217.72.192.221]:50799 "EHLO fmmailgate01.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755380Ab1FEO6Z (ORCPT ); Sun, 5 Jun 2011 10:58:25 -0400 In-Reply-To: <4DEB9033.9060109@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig88DAAEE34D9FB08C43F98487 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2011-06-05 16:18, Avi Kivity wrote: > On 06/05/2011 05:13 PM, Jan Kiszka wrote: >> On 2011-06-05 14:21, Avi Kivity wrote: >> > On 06/03/2011 06:53 PM, Jan Kiszka wrote: >> >> >> @@ -310,6 +310,7 @@ struct kvm_translation { >> >> >> struct kvm_interrupt { >> >> >> /* in */ >> >> >> __u32 irq; >> >> >> + __u8 raise; >> >> >> }; >> >> > >> >> > This touches an existing ABI and corrupts the definition of >> >> > KVM_INTERRUPT IOCTL. The might exist jurisdictions considering= >> this a >> >> > capital crime. :) >> >> > >> >> > You rather have to define a new CPU IRQ injection interface th= at >> >> > supports both raising and lowering >> > >> > This is KVM_IRQ_LINE: >> > >> >> It's so far associated with in-kernel irqchip input pins, not with >> raising CPU IRQs. >=20 > It's up to the architecture to define what it's connected to. >=20 > Note that with KVM_SET_GSI_ROUTING (bad name for ARM...) we can even > choose if an irq line is connected to a kernel-emulated interrupt > controller or to the core's irq input. Makes some sense: Add KVM_IRQ_ROUTING_CPU, and kvm_irq_routing_entry's union would require some struct kvm_irq_routing_cpu containing the target identifier. However, I would recommend to carefully check the generic irq routing bits before use - if they still contain some x86/ia64 specifics or unwanted irqchip_in_kernel(). Jan --------------enig88DAAEE34D9FB08C43F98487 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk3rmY4ACgkQitSsb3rl5xStkACg0DUPdz/wsXxj2g8NxhjjInR0 s9AAn2oy73A6s4W6V5jMH865ETIJ/I12 =3+Re -----END PGP SIGNATURE----- --------------enig88DAAEE34D9FB08C43F98487--