Re: [PATCH v3 1/8] ARM: KVM: Initial skeleton to compile KVM support

[Avi Kivity <avi@redhat.com>]

On 06/05/2011 05:58 PM, Jan Kiszka wrote:
> >
> >  Note that with KVM_SET_GSI_ROUTING (bad name for ARM...) we can even
> >  choose if an irq line is connected to a kernel-emulated interrupt
> >  controller or to the core's irq input.
>
> Makes some sense: Add KVM_IRQ_ROUTING_CPU, and kvm_irq_routing_entry's
> union would require some struct kvm_irq_routing_cpu containing the
> target identifier.

Right.  Note it would be the default, so no need to implement 
KVM_SET_GSI_ROUTING just yet.

An additional advantage is that this is a vm ioctl, not a vcpu ioctl, so 
no need to interrupt the vcpu thread in userspace in order to queue an 
interrupt.  Of course, it still happens in the kernel, but it's easier 
for userspace to implement its device model this way.

> However, I would recommend to carefully check the generic irq routing
> bits before use - if they still contain some x86/ia64 specifics or
> unwanted irqchip_in_kernel().

Most likely yes.

-- 
error compiling committee.c: too many arguments to function