From: Avi Kivity <avi@redhat.com>
To: Pekka Enberg <penberg@kernel.org>
Cc: kvm@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Cyrill Gorcunov <gorcunov@gmail.com>,
John Floren <john@jfloren.net>,
Sasha Levin <levinsasha928@gmail.com>
Subject: Re: [PATCH 2/2] kvm tools, vesa: Fix 'ah' access in int10_vesa()
Date: Mon, 06 Jun 2011 11:28:56 +0300 [thread overview]
Message-ID: <4DEC8FC8.8090601@redhat.com> (raw)
In-Reply-To: <1307129824-8396-2-git-send-email-penberg@kernel.org>
On 06/03/2011 10:37 PM, Pekka Enberg wrote:
> This patch fixes access to 'ah' in int10_vesa() by masking the high bits.
>
> @@ -131,7 +131,7 @@ static void int10_vesa(struct int10_args *args)
> {
> u8 al;
>
> - al = args->eax;
> + al = args->eax& 0xff;
Isn't this reading %al? And the high bits are masked by the type of the
variable?
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-06-06 8:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-03 19:37 [PATCH 1/2] kvm tools, vesa: Cleanup code in bios/int10.c Pekka Enberg
2011-06-03 19:37 ` [PATCH 2/2] kvm tools, vesa: Fix 'ah' access in int10_vesa() Pekka Enberg
2011-06-03 19:43 ` Cyrill Gorcunov
2011-06-06 8:28 ` Avi Kivity [this message]
2011-06-06 8:37 ` Cyrill Gorcunov
2011-06-06 9:09 ` Pekka Enberg
2011-06-06 9:11 ` Cyrill Gorcunov
2011-06-03 19:45 ` [PATCH 1/2] kvm tools, vesa: Cleanup code in bios/int10.c Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DEC8FC8.8090601@redhat.com \
--to=avi@redhat.com \
--cc=gorcunov@gmail.com \
--cc=john@jfloren.net \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=mingo@elte.hu \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox