From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH 2/2] kvm tools, vesa: Fix 'ah' access in int10_vesa()
Date: Mon, 06 Jun 2011 11:28:56 +0300
Message-ID: <4DEC8FC8.8090601@redhat.com>
References: <1307129824-8396-1-git-send-email-penberg@kernel.org> <1307129824-8396-2-git-send-email-penberg@kernel.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
	Cyrill Gorcunov <gorcunov@gmail.com>,
	John Floren <john@jfloren.net>,
	Sasha Levin <levinsasha928@gmail.com>
To: Pekka Enberg <penberg@kernel.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:36097 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1757132Ab1FFI3J (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 6 Jun 2011 04:29:09 -0400
In-Reply-To: <1307129824-8396-2-git-send-email-penberg@kernel.org>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 06/03/2011 10:37 PM, Pekka Enberg wrote:
> This patch fixes access to 'ah' in int10_vesa() by masking the high bits.
>
> @@ -131,7 +131,7 @@ static void int10_vesa(struct int10_args *args)
>   {
>   	u8 al;
>
> -	al = args->eax;
> +	al = args->eax&  0xff;

Isn't this reading %al?  And the high bits are masked by the type of the 
variable?

-- 
error compiling committee.c: too many arguments to function