Re: [PATCH v2] KVM: Clarify KVM_ASSIGN_PCI_DEVICE documentation

[Avi Kivity <avi@redhat.com>]

On 06/03/2011 09:51 AM, Jan Kiszka wrote:
> From: Jan Kiszka<jan.kiszka@siemens.com>
>
> Neither host_irq nor the guest_msi struct are used anymore today.
> Tag the former, drop the latter to avoid confusion.
>

> diff --git a/include/linux/kvm.h b/include/linux/kvm.h
> index 55ef181..9c9ca7c 100644
> --- a/include/linux/kvm.h
> +++ b/include/linux/kvm.h
> @@ -773,20 +773,14 @@ struct kvm_assigned_pci_dev {
>
>   struct kvm_assigned_irq {
>   	__u32 assigned_dev_id;
> -	__u32 host_irq;
> +	__u32 host_irq; /* ignored (legacy field) */
>   	__u32 guest_irq;
>   	__u32 flags;
>   	union {
> -		struct {
> -			__u32 addr_lo;
> -			__u32 addr_hi;
> -			__u32 data;
> -		} guest_msi;
>   		__u32 reserved[12];
>   	};
>   };
>
> -
>   struct kvm_assigned_msix_nr {
>   	__u32 assigned_dev_id;
>   	__u16 entry_nr;

Can we just drop a definition like this?  When did we last use this?

(in fact I can't find when we *ever* used this)

-- 
error compiling committee.c: too many arguments to function