From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH v2] KVM: Clarify KVM_ASSIGN_PCI_DEVICE documentation Date: Mon, 06 Jun 2011 11:42:28 +0300 Message-ID: <4DEC92F4.4010305@redhat.com> References: <4DE79B29.6030609@web.de> <20110603020414.GB7272@amt.cnet> <4DE88459.3010205@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:39180 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757082Ab1FFImc (ORCPT ); Mon, 6 Jun 2011 04:42:32 -0400 In-Reply-To: <4DE88459.3010205@web.de> Sender: kvm-owner@vger.kernel.org List-ID: On 06/03/2011 09:51 AM, Jan Kiszka wrote: > From: Jan Kiszka > > Neither host_irq nor the guest_msi struct are used anymore today. > Tag the former, drop the latter to avoid confusion. > > diff --git a/include/linux/kvm.h b/include/linux/kvm.h > index 55ef181..9c9ca7c 100644 > --- a/include/linux/kvm.h > +++ b/include/linux/kvm.h > @@ -773,20 +773,14 @@ struct kvm_assigned_pci_dev { > > struct kvm_assigned_irq { > __u32 assigned_dev_id; > - __u32 host_irq; > + __u32 host_irq; /* ignored (legacy field) */ > __u32 guest_irq; > __u32 flags; > union { > - struct { > - __u32 addr_lo; > - __u32 addr_hi; > - __u32 data; > - } guest_msi; > __u32 reserved[12]; > }; > }; > > - > struct kvm_assigned_msix_nr { > __u32 assigned_dev_id; > __u16 entry_nr; Can we just drop a definition like this? When did we last use this? (in fact I can't find when we *ever* used this) -- error compiling committee.c: too many arguments to function