From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus Schade Subject: Re: Restoring saved guest causes guest to reboot Date: Mon, 06 Jun 2011 15:57:49 +0200 Message-ID: <4DECDCDD.80709@gmail.com> References: <20110524130208.GJ23407@8bytes.org> <4DDBB085.2010907@redhat.com> <4DDBB5D3.3020403@redhat.com> <4DDCA687.9080506@gmail.com> <4DDDF6D1.1070907@redhat.com> <4DDE3975.6020709@gmail.com> <4DDE6FC0.3010801@gmail.com> <20110526152516.GM23407@8bytes.org> <20110530180246.GA9285@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Joerg Roedel , Avi Kivity , kvm@vger.kernel.org To: Marcelo Tosatti Return-path: Received: from jack.hrz.tu-chemnitz.de ([134.109.132.46]:35593 "EHLO jack.hrz.tu-chemnitz.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753035Ab1FFN6O (ORCPT ); Mon, 6 Jun 2011 09:58:14 -0400 In-Reply-To: <20110530180246.GA9285@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: On 05/30/2011 08:02 PM, Marcelo Tosatti wrote: > On Mon, May 30, 2011 at 02:16:41PM +0200, Markus Schade wrote: >> On Thu, 26 May 2011, Joerg Roedel wrote: >> >>> On Thu, May 26, 2011 at 05:20:32PM +0200, Markus Schade wrote: >>>> On 05/26/2011 01:28 PM, Markus Schade wrote: >>>>> On 05/26/2011 08:44 AM, Avi Kivity wrote: >>>>>> On 05/25/2011 09:49 AM, Markus Schade wrote: >>>>>>> >>>>>>> Git bisect tells me that this is the first bad commit: >>>>>>> -----------------%<----------------- >>>>>>> aff48baa34c033318ad322ecbf2e4bcd891b29ca is the first bad commit >>>>>> >>>>>> Does your machine have ept? >>>>>> >>>>>> (cat /sys/module/kvm_intel/parameters/ept) >>>>>> >>>>> >>>>> Sure. (Assuming that the Y means yes). I am no C developer, but I was >>>>> wondering, if the issue is related to the difference in >>>>> ept_update_paging_mode_cr0 between original patch in the kvm git and the >>>>> linux-2.6. git tree. >>>> >>>> I have re-added the missing 4 lines to ept_update_paging_mode_cr0 in >>>> vmx.c, which resolves this issue for in Kernel 2.6,37 and 2.6.39. >>>> I haven't tested all guests, but neither Squeeze nor 2008 R2 reboot anymore. > > Please check whether the following patch fixes the problem for you. Marcelo, your patch fixes the problem as well (tested in 2.6.39.1). Thanks a lot. Markus