From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH v2] KVM: Clarify KVM_ASSIGN_PCI_DEVICE documentation Date: Mon, 06 Jun 2011 21:57:48 +0200 Message-ID: <4DED313C.9080709@web.de> References: <4DE79B29.6030609@web.de> <20110603020414.GB7272@amt.cnet> <4DE88459.3010205@web.de> <4DEC92F4.4010305@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigD2F394FE70F2D5FF9493E406" Cc: Marcelo Tosatti , kvm To: Avi Kivity Return-path: Received: from fmmailgate03.web.de ([217.72.192.234]:33458 "EHLO fmmailgate03.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751685Ab1FFT5z (ORCPT ); Mon, 6 Jun 2011 15:57:55 -0400 In-Reply-To: <4DEC92F4.4010305@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigD2F394FE70F2D5FF9493E406 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2011-06-06 10:42, Avi Kivity wrote: > On 06/03/2011 09:51 AM, Jan Kiszka wrote: >> From: Jan Kiszka >> >> Neither host_irq nor the guest_msi struct are used anymore today. >> Tag the former, drop the latter to avoid confusion. >> >=20 >> diff --git a/include/linux/kvm.h b/include/linux/kvm.h >> index 55ef181..9c9ca7c 100644 >> --- a/include/linux/kvm.h >> +++ b/include/linux/kvm.h >> @@ -773,20 +773,14 @@ struct kvm_assigned_pci_dev { >> >> struct kvm_assigned_irq { >> __u32 assigned_dev_id; >> - __u32 host_irq; >> + __u32 host_irq; /* ignored (legacy field) */ >> __u32 guest_irq; >> __u32 flags; >> union { >> - struct { >> - __u32 addr_lo; >> - __u32 addr_hi; >> - __u32 data; >> - } guest_msi; >> __u32 reserved[12]; >> }; >> }; >> >> - >> struct kvm_assigned_msix_nr { >> __u32 assigned_dev_id; >> __u16 entry_nr; >=20 > Can we just drop a definition like this? When did we last use this? >=20 > (in fact I can't find when we *ever* used this) >=20 The kernel interface was present between in 2.6.29 only. The fact that we simply dropped that API (replacing it with the current one) indicates that no one was expecting this to be actually used. I also do not find any traces of the old way of assigning MSIs in qemu-kv= m. Jan --------------enigD2F394FE70F2D5FF9493E406 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk3tMUAACgkQitSsb3rl5xR9SwCgz94hIc+la8oHWL2WrpcMOuCN XTcAnA1cI6p1AaS0A1Sra4LNCoIU9y0s =opT/ -----END PGP SIGNATURE----- --------------enigD2F394FE70F2D5FF9493E406--