From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH] pci-assign: Do not reset the device unless the kernel supports it Date: Tue, 07 Jun 2011 00:04:10 +0200 Message-ID: <4DED4EDA.80803@web.de> References: <4DED470F.4020203@web.de> <1307396894.5901.5.camel@x201> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig3381ED41205881FC95757CC2" Cc: Avi Kivity , Marcelo Tosatti , kvm To: Alex Williamson Return-path: Received: from fmmailgate01.web.de ([217.72.192.221]:52105 "EHLO fmmailgate01.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753108Ab1FFWEQ (ORCPT ); Mon, 6 Jun 2011 18:04:16 -0400 In-Reply-To: <1307396894.5901.5.camel@x201> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig3381ED41205881FC95757CC2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2011-06-06 23:48, Alex Williamson wrote: > On Mon, 2011-06-06 at 23:30 +0200, Jan Kiszka wrote: >> From: Jan Kiszka >> >> At least kernels 2.6.38 and 2.6.39 do not properly support issuing a >> reset on an assigned device and corrupt its config space. Prevent >> this by checking for a host kernel with the required support, tagged b= y >> the to-be-introduced KVM_CAP_DEVICE_RESET. >=20 > Wouldn't it be easier just to revert ed78661f in 2.6.39 stable? I gues= s > we don't have an option to do that for .38 since stable is done there, > but there are also some intel-iommu breakages that won't make stable fo= r > that release. It seems like the userspace invoked reset resolves known= , > demonstrable issues of devices continuing to DMA into guest memory whil= e > ed78661f is mostly a theoretical change. Easier would be this patch. But I don't mind reverting the problematic commit in 39, whatever is preferred. We should just resolve the issue finally. >=20 >> Signed-off-by: Jan Kiszka >> --- >> >> PS: What's the state of those KVM patches? Will they make it into 3.0?= >=20 > The PCI save/restore ones are in: >=20 > f8fcfd775523347afe460dc3a0f45d0479e784a2 > ffbdd3f7931fb7cb7e36d00d16303ec433be5145 > 24a4742f0be6226eb0106fbb17caf4d711d1ad43 Oh, they are just missing in kvm.git so far. Jan --------------enig3381ED41205881FC95757CC2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk3tTt4ACgkQitSsb3rl5xShOwCgnp6yl1YwZpiEIBnchSnJt3Z/ oyUAnRuywrMzS0bplJHHZbeC/OM47mGI =gZkG -----END PGP SIGNATURE----- --------------enig3381ED41205881FC95757CC2--