Re: [PATCH] pci-assign: Do not reset the device unless the kernel supports it

Avi Kivity
2011-06-09T08:10:14Z

On 06/07/2011 09:46 PM, Alex Williamson wrote:
> Revert "KVM: Save/restore state of assigned PCI device"
>
> From: Alex Williamson<alex.williamson@redhat.com>
>
> This reverts ed78661f2614d3c9f69c23e280db3bafdabdf5bb as it assumes
> the saved PCI state will remain valid for the entire length of time
> that it is attached to a guest. This fails when userspace makes use
> of the pci-sysfs reset interface, which invalidates the saved device
> state, leaving nothing to be restored after the device is reset on
> de-assignment. This leaves the device in an unusable state.
>
> 3.0.0 will add an interface for KVM to save the PCI state in a
> buffer unaffected by other callers of pci_reset_function(), but the
> most appropriate stable fix seems to be reverting this change since
> the original assumption about the device saved state persisting is
> incorrect.
>

Thanks, queued for 2.6.39.

--
error compiling committee.c: too many arguments to function