From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [PATCH 01/12] Add kernel header update script
Date: Wed, 08 Jun 2011 16:39:19 +0200
Message-ID: <4DEF8997.7050108@siemens.com>
References: <cover.1307542247.git.jan.kiszka@siemens.com>	<b7e14da2dbade9affee696a5997db1df5019ce43.1307542247.git.jan.kiszka@siemens.com> <BANLkTikUc8Dr8hYMgUqbLjbwBPWrbVvEyQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: Avi Kivity <avi@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	Alexander Graf <agraf@suse.de>, Christoph Hellwig <hch@lst.de>,
	=?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <andreas.faerber@web.de>
To: Peter Maydell <peter.maydell@linaro.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from david.siemens.de ([192.35.17.14]:24474 "EHLO david.siemens.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752870Ab1FHOj0 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 8 Jun 2011 10:39:26 -0400
In-Reply-To: <BANLkTikUc8Dr8hYMgUqbLjbwBPWrbVvEyQ@mail.gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 2011-06-08 16:33, Peter Maydell wrote:
> On 8 June 2011 15:10, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>> --- /dev/null
>> +++ b/scripts/update-linux-headers.sh
>> @@ -0,0 +1,55 @@
>> +#!/bin/sh -e
>> +#
> 
>> +if [ -z "$output" ]; then
>> +    output=$PWD
>> +fi
> 
>> +    mkdir -p $output/linux-headers/asm-$arch
> 
> This script is rather lacking in quoting throughout. As a random
> example, this looks like it will break if you run the script from
> a directory with a space in the path.

True.

> 
>> +tmpdir=$TMPDIR/.tmp-hdrs-$$
> 
> Better (safer) to use mktemp, I think.

Is that portable? I don't think so.

> 
>> if [ -z "$linux" -o ! -d "$linux" ]; then
> 
> test -o is obsolescent in POSIX; use
>  if [ -z "$linux" ] || ! [ -d "$linux" ] ; then
> instead.
> 

OK.

Thanks,
Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux