public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: Jan Kiszka <jan.kiszka@web.de>,
	Marcelo Tosatti <mtosatti@redhat.com>, kvm <kvm@vger.kernel.org>
Subject: Re: [PATCH] pci-assign: Do not reset the device unless the kernel supports it
Date: Thu, 09 Jun 2011 11:10:10 +0300	[thread overview]
Message-ID: <4DF07FE2.7000702@redhat.com> (raw)
In-Reply-To: <1307472373.5901.33.camel@x201>

On 06/07/2011 09:46 PM, Alex Williamson wrote:
> Revert "KVM: Save/restore state of assigned PCI device"
>
> From: Alex Williamson<alex.williamson@redhat.com>
>
> This reverts ed78661f2614d3c9f69c23e280db3bafdabdf5bb as it assumes
> the saved PCI state will remain valid for the entire length of time
> that it is attached to a guest.  This fails when userspace makes use
> of the pci-sysfs reset interface, which invalidates the saved device
> state, leaving nothing to be restored after the device is reset on
> de-assignment.  This leaves the device in an unusable state.
>
> 3.0.0 will add an interface for KVM to save the PCI state in a
> buffer unaffected by other callers of pci_reset_function(), but the
> most appropriate stable fix seems to be reverting this change since
> the original assumption about the device saved state persisting is
> incorrect.
>

Thanks, queued for 2.6.39.

-- 
error compiling committee.c: too many arguments to function


      parent reply	other threads:[~2011-06-09  8:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-06 21:30 [PATCH] pci-assign: Do not reset the device unless the kernel supports it Jan Kiszka
2011-06-06 21:48 ` Alex Williamson
2011-06-06 22:04   ` Jan Kiszka
2011-06-07  8:06     ` Avi Kivity
2011-06-07  8:14       ` Jan Kiszka
2011-06-07 18:46         ` Alex Williamson
2011-06-08  7:52           ` Jan Kiszka
2011-06-09  8:10           ` Avi Kivity [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DF07FE2.7000702@redhat.com \
    --to=avi@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=jan.kiszka@web.de \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox