From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] pci-assign: Do not reset the device unless the kernel supports it Date: Thu, 09 Jun 2011 11:10:10 +0300 Message-ID: <4DF07FE2.7000702@redhat.com> References: <4DED470F.4020203@web.de> <1307396894.5901.5.camel@x201> <4DED4EDA.80803@web.de> <4DEDDC1D.7000905@redhat.com> <4DEDDDDE.4010209@web.de> <1307472373.5901.33.camel@x201> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Jan Kiszka , Marcelo Tosatti , kvm To: Alex Williamson Return-path: Received: from mx1.redhat.com ([209.132.183.28]:23040 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757024Ab1FIIKO (ORCPT ); Thu, 9 Jun 2011 04:10:14 -0400 In-Reply-To: <1307472373.5901.33.camel@x201> Sender: kvm-owner@vger.kernel.org List-ID: On 06/07/2011 09:46 PM, Alex Williamson wrote: > Revert "KVM: Save/restore state of assigned PCI device" > > From: Alex Williamson > > This reverts ed78661f2614d3c9f69c23e280db3bafdabdf5bb as it assumes > the saved PCI state will remain valid for the entire length of time > that it is attached to a guest. This fails when userspace makes use > of the pci-sysfs reset interface, which invalidates the saved device > state, leaving nothing to be restored after the device is reset on > de-assignment. This leaves the device in an unusable state. > > 3.0.0 will add an interface for KVM to save the PCI state in a > buffer unaffected by other callers of pci_reset_function(), but the > most appropriate stable fix seems to be reverting this change since > the original assumption about the device saved state persisting is > incorrect. > Thanks, queued for 2.6.39. -- error compiling committee.c: too many arguments to function