From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH v2] KVM: Clarify KVM_ASSIGN_PCI_DEVICE documentation Date: Thu, 09 Jun 2011 11:13:17 +0300 Message-ID: <4DF0809D.6080805@redhat.com> References: <4DE79B29.6030609@web.de> <20110603020414.GB7272@amt.cnet> <4DE88459.3010205@web.de> <4DEC92F4.4010305@redhat.com> <4DED313C.9080709@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:42586 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755467Ab1FIINV (ORCPT ); Thu, 9 Jun 2011 04:13:21 -0400 In-Reply-To: <4DED313C.9080709@web.de> Sender: kvm-owner@vger.kernel.org List-ID: On 06/06/2011 10:57 PM, Jan Kiszka wrote: > > > > Can we just drop a definition like this? When did we last use this? > > > > (in fact I can't find when we *ever* used this) > > > > The kernel interface was present between in 2.6.29 only. The fact that > we simply dropped that API (replacing it with the current one) indicates > that no one was expecting this to be actually used. > > I also do not find any traces of the old way of assigning MSIs in qemu-kvm. > Okay. There's some remote possibility that someone will pick up .29 and develop for it, but I think we can ignore that. Applied. -- error compiling committee.c: too many arguments to function