Re: [PATCH][uq/master] kvm: x86: Save/restore FPU OP, IP and DP

Avi Kivity
2011-06-13T08:45:51Z

On 06/11/2011 12:23 PM, Jan Kiszka wrote:
> From: Jan Kiszka<jan.kiszka@siemens.com>
>
> These FPU states are properly maintained by KVM but not yet by TCG. So
> far we unconditionally set them to 0 in the guest which may cause
> state corruptions - not only during migration.
>
>
> -#define CPU_SAVE_VERSION 12
> +#define CPU_SAVE_VERSION 13
>

Incrementing the version number seems excessive - I can't imagine a
real-life guest will break due to fp pointer corruption

However, I don't think we have a mechanism for optional state. We
discussed this during the 18th VMState Subsection Symposium and IIRC
agreed to re-raise the issue when we encountered it, which appears to be
now.

--
error compiling committee.c: too many arguments to function